The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
react-native-firebase	Ready	Preview	Comment	Sep 13, 2025 6:13pm

All committers have signed the CLA.

Can you write a test for this please?

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

It is nearly impossible to write automated tests for these storage upload/download methods because they run against an in-memory emulator on same host as the client, so there is insufficient delay (even with very large files) for a test to work.

I believe the only valid tests would work against cloud storage vs the emulator - which is possible now.

This is the entry point for our local tests:

https://github.com/invertase/react-native-firebase/blob/main/tests/local-tests/index.js

And if you run yarn tests:android:manual or yarn tests:ios:manual then use the little top menu of manual tests in the app once it starts, you can exercise something difficult to automate. If you do not put an emulator call in there it will go against the cloud storage, so in that way you could easily do a little test React Component that uploaded a file (then downloaded it and compared it I suppose) to make sure it was working.

None of the CI errors are related to this PR - if you rebase to current main in this repo there are a bunch of CI fixes that should see things go green

@johnsimeroth is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

@mikehardy

The code seems reasonable - I assume this is working for you @johnsimeroth ?

Apologies for the delay! Looks like I need to sort out my github notification settings, I wasn't getting any of the responses here and I honestly forgot about this PR.

Yes, the code is the same that I added to my app, and it's been working as expected without issue.

It is nearly impossible to write automated tests for these storage upload/download methods because they run against an in-memory emulator on same host as the client, so there is insufficient delay (even with very large files) for a test to work.

I believe the only valid tests would work against cloud storage vs the emulator - which is possible now.

This is the entry point for our local tests:

https://github.com/invertase/react-native-firebase/blob/main/tests/local-tests/index.js

And if you run yarn tests:android:manual or yarn tests:ios:manual then use the little top menu of manual tests in the app once it starts, you can exercise something difficult to automate. If you do not put an emulator call in there it will go against the cloud storage, so in that way you could easily do a little test React Component that uploaded a file (then downloaded it and compared it I suppose) to make sure it was working.

That seems sensible - If you'd like to see that setup as part of this PR I can find some time next week to take a crack at it.

None of the CI errors are related to this PR - if you rebase to current main in this repo there are a bunch of CI fixes that should see things go green

In the interim, I've rebased as requested.